-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fast dataset iter #5030
Fast dataset iter #5030
Conversation
The documentation is not available anymore as the PR was closed or merged. |
I ran some benchmarks (focused on the data fetching part of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice thank you ! The benchmarks are super helpful as well, I think you can link to them in comments in the code
Co-authored-by: Quentin Lhoest <42851186+lhoestq@users.noreply.github.com>
Use
pa.Table.to_reader
to make iteration over examples/batches faster inDataset.{__iter__, map}
TODO:
bookcorpus
(75 mil examples) in Colab is approx. 2.3x faster)_iter
yields better performance