[HacktoberFest] Add missing docstrings to diffusers/models #5248
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yiyixuxu
approved these changes
Oct 6, 2023
src/diffusers/models/controlnet.py
Outdated
Comment on lines
674
to
675
| Conditional embeddings for timestep. If provided, the embeddings will be summed with the samples | ||
| passed through the `self.time_embedding` layer to obtain the timestep embeddings. |
Collaborator
There was a problem hiding this comment.
Suggested change
| Conditional embeddings for timestep. If provided, the embeddings will be summed with the samples | |
| passed through the `self.time_embedding` layer to obtain the timestep embeddings. | |
| Additional conditional embeddings for timestep. If provided, the embeddings will be summed with the timestep embedding | |
| passed through the `self.time_embedding` layer to obtain the timestep embeddings. |
Contributor
Author
There was a problem hiding this comment.
Added the suggestion.
Collaborator
|
@a-r-r-o-w don't forget |
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. |
AmericanPresidentJimmyCarter
pushed a commit
to AmericanPresidentJimmyCarter/diffusers
that referenced
this pull request
Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds missing docstrings as mentioned in the linked issue. Also adds docstrings for similar missing cases in other files not mentioned in the original issue.
Fixes #5228
cc: @patrickvonplaten @yiyixuxu