Skip to content

Conversation

@a-r-r-o-w
Copy link
Contributor

What does this PR do?

Fixes #6495 and part of #5685

Before submitting

Who can review?

@yiyixuxu

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@yiyixuxu
Copy link
Collaborator

yiyixuxu commented Feb 8, 2024

I think we need to update the test now that we fixed that function :)

# 5. Prepare timesteps
def denoising_value_valid(dnv):
return isinstance(self.denoising_end, float) and 0 < dnv < 1
return isinstance(dnv, float) and 0 < dnv < 1
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yiyixuxu Could you review please? The tests are now passing locally. I think the initial condition of checking isinstance(self.denoising_end, float) every time was incorrect because you can have denoising_end=None but denoising_start as not None.

Copy link
Collaborator

@yiyixuxu yiyixuxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@yiyixuxu yiyixuxu requested a review from sayakpaul February 24, 2024 01:41
@yiyixuxu yiyixuxu merged commit bbf70c8 into huggingface:main Feb 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Possible bug in pipelines that use denoising_start and denoising_end

4 participants