From faff4f250b1c8b17aa42513ee2b9b2e99f3e0f30 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?M=2E=20Tolga=20Cang=C3=B6z?= Date: Wed, 21 Feb 2024 19:58:54 +0300 Subject: [PATCH 1/5] Refactor save_model_card function to handle images and repo_folder parameters --- examples/text_to_image/train_text_to_image.py | 4 ++-- examples/text_to_image/train_text_to_image_lora.py | 13 +++++++++---- .../text_to_image/train_text_to_image_lora_sdxl.py | 2 +- examples/text_to_image/train_text_to_image_sdxl.py | 9 +++++---- 4 files changed, 17 insertions(+), 11 deletions(-) diff --git a/examples/text_to_image/train_text_to_image.py b/examples/text_to_image/train_text_to_image.py index 6fb8b17944eb..a1b483e6a825 100644 --- a/examples/text_to_image/train_text_to_image.py +++ b/examples/text_to_image/train_text_to_image.py @@ -68,10 +68,10 @@ def save_model_card( args, repo_id: str, images: list = None, - repo_folder: str = None, + repo_folder: str = ".", ): img_str = "" - if len(images) > 0: + if images is not None: image_grid = make_image_grid(images, 1, len(args.validation_prompts)) image_grid.save(os.path.join(repo_folder, "val_imgs_grid.png")) img_str += "![val_imgs_grid](./val_imgs_grid.png)\n" diff --git a/examples/text_to_image/train_text_to_image_lora.py b/examples/text_to_image/train_text_to_image_lora.py index 47e67f695b08..fe0622769f0c 100644 --- a/examples/text_to_image/train_text_to_image_lora.py +++ b/examples/text_to_image/train_text_to_image_lora.py @@ -57,12 +57,17 @@ def save_model_card( - repo_id: str, images: list = None, base_model: str = None, dataset_name: str = None, repo_folder: str = None + repo_id: str, + images: list = None, + base_model: str = None, + dataset_name: str = None, + repo_folder: str = ".", ): img_str = "" - for i, image in enumerate(images): - image.save(os.path.join(repo_folder, f"image_{i}.png")) - img_str += f"![img_{i}](./image_{i}.png)\n" + if images is not None: + for i, image in enumerate(images): + image.save(os.path.join(repo_folder, f"image_{i}.png")) + img_str += f"![img_{i}](./image_{i}.png)\n" model_description = f""" # LoRA text2image fine-tuning - {repo_id} diff --git a/examples/text_to_image/train_text_to_image_lora_sdxl.py b/examples/text_to_image/train_text_to_image_lora_sdxl.py index 79bc66288338..f1bee0df80d2 100644 --- a/examples/text_to_image/train_text_to_image_lora_sdxl.py +++ b/examples/text_to_image/train_text_to_image_lora_sdxl.py @@ -75,7 +75,7 @@ def save_model_card( base_model: str = None, dataset_name: str = None, train_text_encoder: bool = False, - repo_folder: str = None, + repo_folder: str = ".", vae_path: str = None, ): img_str = "" diff --git a/examples/text_to_image/train_text_to_image_sdxl.py b/examples/text_to_image/train_text_to_image_sdxl.py index 292e52bca0f8..ae71d5aebc58 100644 --- a/examples/text_to_image/train_text_to_image_sdxl.py +++ b/examples/text_to_image/train_text_to_image_sdxl.py @@ -70,13 +70,14 @@ def save_model_card( validation_prompt: str = None, base_model: str = None, dataset_name: str = None, - repo_folder: str = None, + repo_folder: str = ".", vae_path: str = None, ): img_str = "" - for i, image in enumerate(images): - image.save(os.path.join(repo_folder, f"image_{i}.png")) - img_str += f"![img_{i}](./image_{i}.png)\n" + if images is not None: + for i, image in enumerate(images): + image.save(os.path.join(repo_folder, f"image_{i}.png")) + img_str += f"![img_{i}](./image_{i}.png)\n" model_description = f""" # Text-to-image finetuning - {repo_id} From 51e7b43477b4084123e6bae4b4a3611bc055414b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?M=2E=20Tolga=20Cang=C3=B6z?= <46008593+standardAI@users.noreply.github.com> Date: Fri, 23 Feb 2024 17:20:04 +0300 Subject: [PATCH 2/5] Discard changes to examples/text_to_image/train_text_to_image.py --- examples/text_to_image/train_text_to_image.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/examples/text_to_image/train_text_to_image.py b/examples/text_to_image/train_text_to_image.py index c574e0240a2a..46516c9198ec 100644 --- a/examples/text_to_image/train_text_to_image.py +++ b/examples/text_to_image/train_text_to_image.py @@ -69,10 +69,10 @@ def save_model_card( args, repo_id: str, images: list = None, - repo_folder: str = ".", + repo_folder: str = None, ): img_str = "" - if images is not None: + if len(images) > 0: image_grid = make_image_grid(images, 1, len(args.validation_prompts)) image_grid.save(os.path.join(repo_folder, "val_imgs_grid.png")) img_str += "![val_imgs_grid](./val_imgs_grid.png)\n" From 819f1cf5be5d547bbf8b3056b055c1b8315e8eba Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?M=2E=20Tolga=20Cang=C3=B6z?= <46008593+standardAI@users.noreply.github.com> Date: Fri, 23 Feb 2024 17:20:34 +0300 Subject: [PATCH 3/5] Discard changes to examples/text_to_image/train_text_to_image_lora_sdxl.py --- examples/text_to_image/train_text_to_image_lora_sdxl.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/examples/text_to_image/train_text_to_image_lora_sdxl.py b/examples/text_to_image/train_text_to_image_lora_sdxl.py index 2d5415f38964..be178d36dcde 100644 --- a/examples/text_to_image/train_text_to_image_lora_sdxl.py +++ b/examples/text_to_image/train_text_to_image_lora_sdxl.py @@ -75,7 +75,7 @@ def save_model_card( base_model: str = None, dataset_name: str = None, train_text_encoder: bool = False, - repo_folder: str = ".", + repo_folder: str = None, vae_path: str = None, ): img_str = "" From c0cd7b3d86d8eff8ab3d24072a172d0bbb5f831a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?M=2E=20Tolga=20Cang=C3=B6z?= <46008593+standardAI@users.noreply.github.com> Date: Fri, 23 Feb 2024 17:23:55 +0300 Subject: [PATCH 4/5] Update train_text_to_image_lora.py --- examples/text_to_image/train_text_to_image_lora.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/examples/text_to_image/train_text_to_image_lora.py b/examples/text_to_image/train_text_to_image_lora.py index 5fedb44e5687..34838500748e 100644 --- a/examples/text_to_image/train_text_to_image_lora.py +++ b/examples/text_to_image/train_text_to_image_lora.py @@ -62,7 +62,7 @@ def save_model_card( images: list = None, base_model: str = None, dataset_name: str = None, - repo_folder: str = ".", + repo_folder: str = None, ): img_str = "" if images is not None: From a49ed8e1f2d98aa1f3d90dc7d9a37b223ce88e30 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?M=2E=20Tolga=20Cang=C3=B6z?= <46008593+standardAI@users.noreply.github.com> Date: Fri, 23 Feb 2024 17:25:55 +0300 Subject: [PATCH 5/5] Update train_text_to_image_sdxl.py --- examples/text_to_image/train_text_to_image_sdxl.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/examples/text_to_image/train_text_to_image_sdxl.py b/examples/text_to_image/train_text_to_image_sdxl.py index 24800ef495f7..2d77e9c8bfa3 100644 --- a/examples/text_to_image/train_text_to_image_sdxl.py +++ b/examples/text_to_image/train_text_to_image_sdxl.py @@ -70,7 +70,7 @@ def save_model_card( validation_prompt: str = None, base_model: str = None, dataset_name: str = None, - repo_folder: str = ".", + repo_folder: str = None, vae_path: str = None, ): img_str = ""