-
Notifications
You must be signed in to change notification settings - Fork 387
[SageMaker] Add warning about SageMaker SDK v3 breaking changes #2095
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SageMaker] Add warning about SageMaker SDK v3 breaking changes #2095
Conversation
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
tengomucho
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you should also add the same warning to this file: https://github.com/huggingface/hub-docs/blob/main/docs/sagemaker/source/dlcs/available.md
Because it has the from sagemaker.huggingface import HuggingFaceModel, get_huggingface_llm_image_uri code.
tengomucho
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
alvarobartt
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ehcalabres, I've suggested a slightly different version for the warning!
…ingface#2095) * Add warning about SageMaker SDK v3 breaking changes * Update SageMaker SDK version in notebooks to avoid breaking changes in v3 * Add missing warnings about SageMaker SDK v3 breaking changes * Update warnings regarding SageMaker Python SDK
Background
Sagemaker team has recently released a new major version of their
sagemaker-python-sdkwith a big refactoring and some breaking changes that directly affect HF's integrations. While we are already working on this new release, all the tutorials and docs related to sagemaker won't work in this new version until updated.Description
This PR adds some warnings to explicitly advice the user about these changes and how to avoid errors by using the previous version (v2).