Skip to content

Conversation

@SBrandeis
Copy link
Contributor

@SBrandeis SBrandeis commented Jan 15, 2025

@SBrandeis SBrandeis changed the base branch from main to inference/refactor-make-requests January 15, 2025 17:01
Base automatically changed from inference/refactor-make-requests to main January 15, 2025 17:50
Copy link
Member

@julien-c julien-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@SBrandeis SBrandeis marked this pull request as ready for review January 16, 2025 14:09
@@ -0,0 +1,2 @@
export const HF_HUB_URL = "https://huggingface.co";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(nit) this constant is usually called HF_ENDPOINT in the Python ecosystem

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For consistency with the other JS packages we'll keep the current name

@SBrandeis SBrandeis merged commit 455f12c into main Jan 17, 2025
5 checks passed
@SBrandeis SBrandeis deleted the inference/proxy branch January 17, 2025 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants