Skip to content

Conversation

@jeffmaury
Copy link
Contributor

Add finer handling of symlink as it is not supported on Windows.

Fixes #1268

Fixes huggingface#1268

Signed-off-by: Jeff MAURY <jmaury@redhat.com>
@jeffmaury jeffmaury requested a review from coyotte508 as a code owner March 12, 2025 14:46
@coyotte508
Copy link
Member

Thanks for the contribution!

cc @Wauplin @hanouticelina for viz since it's also in the python implem

@coyotte508 coyotte508 self-assigned this Mar 13, 2025
Signed-off-by: Jeff MAURY <jmaury@redhat.com>
Copy link
Member

@coyotte508 coyotte508 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

I think we may still want to use relative paths (from what is said in the doc comment) on windows in the symlink, but current version is already an improvement to make it work better in windows.

Approving and will merge in a few days

Copy link
Contributor

@Wauplin Wauplin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

I think we may still want to use relative paths

Agree on that. Absolute paths have caused quite some trouble when I introduced them (and only for a short period of time)

@coyotte508 coyotte508 merged commit 0b13731 into huggingface:main Mar 17, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Hub snapshot_download not compatible with Windows

4 participants