Skip to content

Conversation

@julien-c
Copy link
Member

i think we currently call resolveProvider when a endpointUrl is passed and no provider is passed, but we shouldn't, no?

@julien-c julien-c requested a review from Wauplin April 30, 2025 11:09
@Wauplin
Copy link
Contributor

Wauplin commented May 1, 2025

x-linking internal convo: https://huggingface.slack.com/archives/C07KX53FZTK/p1746026621600159

TL;DR: defaulting to "hf-inference" when passing an endpointUrl allows to reuse most of the logic to build the HTTP request. This is how we do it in Python. It requires some slight changes of makeBaseUrl/makeRoute in hf-inference.ts.

@julien-c
Copy link
Member Author

julien-c commented May 4, 2025

Closed by #1420

@julien-c julien-c closed this May 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants