Add download stats filter for MagentaRT #1620
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
osanseviero
requested review from
SBrandeis,
Wauplin,
gary149,
julien-c,
ngxson and
pcuenca
as code owners
pcuenca
reviewed
Jul 13, 2025
Member
pcuenca
left a comment
pcuenca
left a comment
There was a problem hiding this comment.
Looks good! We'd also need a corresponding PR in https://huggingface.co/google/magenta-realtime to set the library name, wouldn't we?
|
Library name has been set, thanks! https://huggingface.co/google/magenta-realtime/commit/c1578ac0682a4849f6313d8e57ff9b6c6139fcc8 |
|
@Wauplin thanks for the review! I'm one of the Magenta RealTime owners, looking forward to getting this merged. Do you happen to have any insights on why the browser test is failing on this case? |
Contributor
|
Hi @KEHANG , failing CI is unrelated so we can merge it now :) Expect 3-4 days before getting it live on the Hub! |
|
Thanks @Wauplin ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.