xet chunker is created for each file instead of reused #1738
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coyotte508
force-pushed
the
assaf/recreate-chunker-at-end-of-file-processing-xet-upload
branch
from
352086b to
8e66774
Compare
coyotte508
approved these changes
Sep 10, 2025
coyotte508
deleted the
assaf/recreate-chunker-at-end-of-file-processing-xet-upload
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to create a fresh Chunker object for each file we process to avoid the last bytes from the previous file to impact the hash used to generate chunk boundaries.
This gets ride of the
try {} finally {chunker.free()}at the end of file processing so this causes a lot of code to be de-indented, changes are pretty minimal.