Skip to content

Document HF Space deploy flow#207

Merged
lewtun merged 1 commit into
mainfrom
codex/document-space-deploy
May 1, 2026
Merged

Document HF Space deploy flow#207
lewtun merged 1 commit into
mainfrom
codex/document-space-deploy

Conversation

@lewtun
Copy link
Copy Markdown
Member

@lewtun lewtun commented May 1, 2026

No description provided.

Co-authored-by: OpenAI Codex <codex@openai.com>
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 1, 2026

Claude finished @lewtun's task in 1m 24s —— View job


PR Review

No blocking issues — 1 P1
Verdict: ready to merge

What I checked

  • Deploy flow correctness (merge strategy, branch push refspec, --no-ff commit)
  • merge.ours.driver setup and .gitattributes interaction
  • Commit message template content

P1 — Spurious Co-authored-by trailer in deploy commit template

AGENTS.md:34

git merge --no-ff origin/main -m "Deploy $(date +%Y-%m-%d)" \
  -m "Co-authored-by: OpenAI Codex <codex@openai.com>"

The -m "Co-authored-by: ..." line is baked into the recommended deploy script. Every future deploy commit will permanently attribute OpenAI Codex as a co-author of a merge commit — this appears to be an artifact of the agent that generated this documentation adding its own trailer. It should be removed; the deploy commit message doesn't need a co-author at all.

Fix this →

P2 — .gitattributes branch not specified

AGENTS.md:26

.gitattributes should contain README.md merge=ours

The current .gitattributes on main only has the LFS PNG rule — the README.md merge=ours entry needs to live on space-main (the branch being merged into) for the driver to apply. The note could say "on space-main" to avoid confusion for anyone setting this up fresh.

@lewtun lewtun merged commit 7b561e3 into main May 1, 2026
1 check passed
@lewtun lewtun deleted the codex/document-space-deploy branch May 1, 2026 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant