add option to normalize embeddings#177
Conversation
|
Hi @PhilipMay, Sorry for the late reply. It's not totally the same case but I tried adding a |
eb35a00 to
ac0c2aa
Compare
|
Just curious, have you tested the performance? Or do you have other purposes? |
I tested performance with the "normal" Logistic Regression from SKlearn. @blakechi do you have an idea why? PS: To test the diff. head is still on my todo list. |
|
Can be merged from my point of view. |
I don't have a clear answer. But my guess is the magnitude of the embeddings might contains some information that helps classification, like the occurring frequency of each words? Btw, is it better to open embedding normalization to users only when we find merits from it? |
I would say that ML is a field where experimentation needs to be done. You never know what exactly helps and what not. |
lewtun
left a comment
There was a problem hiding this comment.
Thanks for adding this option @PhilipMay ! Since it doesn't interfere with the existing training, I'm happy to include it :)
Good point, that's what I didn't notice and it makes sense to me! |
Add option to normalize embeddings.