Skip to content

add option to set samples_per_label - #196

Merged
lewtun merged 1 commit into
huggingface:mainfrom
PhilipMay:add_samples_per_label_option
Nov 23, 2022
Merged

lewtun merged 1 commit into
huggingface:mainfrom
PhilipMay:add_samples_per_label_option

Conversation

@PhilipMay

@PhilipMay PhilipMay commented Nov 18, 2022 •

Copy link
Copy Markdown
Contributor

This PR adds the option to set samples_per_label in the SentenceLabelDataset when you train with triplet loss.

See here in sbert doc:
https://github.com/UKPLab/sentence-transformers/blob/0b5ef4be93d2b21de3a918a084b48aab6ba48595/sentence_transformers/datasets/SentenceLabelDataset.py#L31-L32

@PhilipMay

Copy link
Copy Markdown
Contributor Author

Not sure how to add tests to be honest.

This PR is done from my point of view... CI is green.

@lewtun lewtun left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this option @PhilipMay - LGTM!

@lewtun
lewtun merged commit fa1021d into huggingface:main Nov 23, 2022
@PhilipMay
PhilipMay deleted the add_samples_per_label_option branch November 23, 2022 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants