Add support for files endpoints #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds comprehensive file operations functionality to the HuggingFace SDK, enabling upload, download, listing, and deletion of files in Hugging Face repositories.
- Implements file upload with automatic streaming for large files (>10MB)
- Adds file download with progress tracking and resume capability
- Provides file existence checking, listing, and metadata retrieval
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| Sources/HuggingFace/Hub/HubClient+Files.swift | Core file operations implementation including upload, download, delete, and query operations |
| Sources/HuggingFace/Hub/File.swift | Data structures for file metadata and batch upload operations |
| Sources/HuggingFace/Shared/MultipartBuilder.swift | Multipart form-data builder supporting both in-memory and streaming approaches |
| Sources/HuggingFace/Shared/HTTPClient.swift | Added HEAD method support and made helper methods public for file operations |
| Tests/HuggingFaceTests/HubTests/FileOperationsTests.swift | Comprehensive test coverage for all file operations |
| README.md | Documentation and usage examples for new file operations API |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.