Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add inputs_embeds support for .generate() with BLOOM models #21430

Merged
merged 1 commit into from Feb 3, 2023
Merged

Add inputs_embeds support for .generate() with BLOOM models #21430

merged 1 commit into from Feb 3, 2023

Conversation

akreal
Copy link
Contributor

@akreal akreal commented Feb 2, 2023

What does this PR do?

Adds accepting .generate() calls with inputs_embeds on BLOOM models (following GPT2 example in #21405).

Before submitting

  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@gante

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Feb 2, 2023

The documentation is not available anymore as the PR was closed or merged.

Copy link
Member

@gante gante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic, thank you for adding it 👍

@gante
Copy link
Member

gante commented Feb 3, 2023

There seems to be a CircleCI issue when triggering the tests 🤔

@akreal could you try following these instructions? I'm not sure whether they will help, but they were the closest match I found based on CircleCI's error message.

@gante gante requested a review from sgugger February 3, 2023 10:12
Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!

@sgugger sgugger merged commit 3560ae6 into huggingface:main Feb 3, 2023
@akreal akreal deleted the generate_inputs_embeds_bloom branch February 3, 2023 12:32
Shubhamai pushed a commit to Shubhamai/transformers that referenced this pull request Feb 6, 2023
…ingface#21430)

Add accepting `.generate()` calls with `inputs_embeds` on BLOOM models
miyu386 pushed a commit to miyu386/transformers that referenced this pull request Feb 9, 2023
…ingface#21430)

Add accepting `.generate()` calls with `inputs_embeds` on BLOOM models
ArthurZucker pushed a commit to ArthurZucker/transformers that referenced this pull request Mar 2, 2023
…ingface#21430)

Add accepting `.generate()` calls with `inputs_embeds` on BLOOM models
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants