add classifier_dropout to classification heads - #12794
Merged
Merged
Conversation
PhilipMay
changed the title
classifier_dropout to classification headsclassifier_dropout to classification heads
sgugger
approved these changes
Jul 19, 2021
sgugger
left a comment
sgugger
left a comment
Collaborator
There was a problem hiding this comment.
This can be added to the other models too!
PhilipMay
force-pushed
the
add_head_dropout
branch
3 times, most recently
from
July 19, 2021 18:40
cc8d91e to
4714546
Compare
Co-authored-by: Sylvain Gugger <35901082+sgugger@users.noreply.github.com>
Contributor
Author
|
@sgugger should |
PhilipMay
force-pushed
the
add_head_dropout
branch
2 times, most recently
from
July 19, 2021 19:10
250a952 to
4714546
Compare
Collaborator
|
It should be used for both, yes. |
patrickvonplaten
approved these changes
Jul 20, 2021
Contributor
Author
|
This is still WIP - I want to add more models. Please do not merge yet ... |
PhilipMay
force-pushed
the
add_head_dropout
branch
from
July 20, 2021 19:19
36ea292 to
0ea13d6
Compare
Closed
PhilipMay
changed the title
classifier_dropout to classification headsclassifier_dropout to classification heads
Contributor
Author
|
I am done with this PR. It is ready for review. |
sgugger
approved these changes
Jul 26, 2021
sgugger
left a comment
sgugger
left a comment
Collaborator
There was a problem hiding this comment.
Thanks again for working on this!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR for #12781 and maybe a fix for #12792
Logbook
SequenceClassificationandTokenClassificationSequenceClassificationandTokenClassificationSequenceClassificationandTokenClassificationSequenceClassificationandTokenClassificationSequenceClassificationandTokenClassificationSequenceClassificationandTokenClassificationSequenceClassificationandTokenClassificationSequenceClassificationandTokenClassification