Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add WavLM #14354

Merged
merged 34 commits into from Dec 16, 2021
Merged

Add WavLM #14354

merged 34 commits into from Dec 16, 2021

Conversation

patrickvonplaten
Copy link
Contributor

@patrickvonplaten patrickvonplaten commented Nov 10, 2021

What does this PR do?

Paper: https://arxiv.org/pdf/2110.13900.pdf
Checkpoints: https://huggingface.co/models?other=wavlm

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@felixlut
Copy link

Hey, any idea when WavLM will be integrated to the 🤗-platform?

README_ko.md Outdated Show resolved Hide resolved
README_zh-hans.md Outdated Show resolved Hide resolved
README_zh-hans.md Outdated Show resolved Hide resolved
README_zh-hant.md Outdated Show resolved Hide resolved
@patrickvonplaten patrickvonplaten changed the title [WIP][Wavlm] Add WavLM Dec 13, 2021
@patrickvonplaten
Copy link
Contributor Author

Can't reproduce doc failures locally

Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this!
The doc building test job should work once you rebase on master.

README_zh-hans.md Outdated Show resolved Hide resolved
README_zh-hans.md Outdated Show resolved Hide resolved
README_zh-hant.md Outdated Show resolved Hide resolved
README_zh-hant.md Outdated Show resolved Hide resolved
src/transformers/models/wavlm/modeling_wavlm.py Outdated Show resolved Hide resolved
src/transformers/models/wavlm/modeling_wavlm.py Outdated Show resolved Hide resolved
src/transformers/models/wavlm/modeling_wavlm.py Outdated Show resolved Hide resolved
Copy link
Member

@LysandreJik LysandreJik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very clean, LGTM

@patrickvonplaten
Copy link
Contributor Author

Merging now. @anton-l - feel free to make some final changes when you add the WavLM heads

@patrickvonplaten patrickvonplaten merged commit bef1e3e into huggingface:master Dec 16, 2021
@patrickvonplaten patrickvonplaten deleted the add_wavlm branch December 16, 2021 17:57
kct22aws pushed a commit to kct22aws/transformers that referenced this pull request Dec 16, 2021
* first commit

* fix some stuff

* fix more readme

* Apply suggestions from code review

* update

* correct

* up

* attn layer works

* push code

* make modedls work

* Small change

* more refactor

* finish

* up

* fix convertsion

* fix position bias

* Fix style

* fix conversion

* make fix-copies

* add

* clean

* fix docs

* fix

* Apply suggestions from code review

Co-authored-by: Sylvain Gugger <35901082+sgugger@users.noreply.github.com>

* apply final changes

* make fix-copies

Co-authored-by: Sylvain Gugger <35901082+sgugger@users.noreply.github.com>
Albertobegue pushed a commit to Albertobegue/transformers that referenced this pull request Jan 27, 2022
* first commit

* fix some stuff

* fix more readme

* Apply suggestions from code review

* update

* correct

* up

* attn layer works

* push code

* make modedls work

* Small change

* more refactor

* finish

* up

* fix convertsion

* fix position bias

* Fix style

* fix conversion

* make fix-copies

* add

* clean

* fix docs

* fix

* Apply suggestions from code review

Co-authored-by: Sylvain Gugger <35901082+sgugger@users.noreply.github.com>

* apply final changes

* make fix-copies

Co-authored-by: Sylvain Gugger <35901082+sgugger@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants