Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Flax tests] Disable scheduled GPU tests #15503

Merged

Conversation

patrickvonplaten
Copy link
Contributor

@patrickvonplaten patrickvonplaten commented Feb 3, 2022

What does this PR do?

The GPU tests are running forever at the moment and take up the whole gpu-test machine all the time. @patil-suraj we should probably sit together next week to investigate this a bit, make them much faster and then re-enable them.

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@HuggingFaceDocBuilder
Copy link

HuggingFaceDocBuilder commented Feb 3, 2022

The documentation is not available anymore as the PR was closed or merged.

Copy link
Member

@LysandreJik LysandreJik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Happy to sit down with you and talk about it, I've observed similar slowdowns on per-model GPU flax tests.

@patrickvonplaten
Copy link
Contributor Author

It's the compilation that takes for ever I think. I'll investigate a bit with @patil-suraj next week

@patrickvonplaten patrickvonplaten merged commit e2b6e73 into huggingface:master Feb 3, 2022
@patrickvonplaten patrickvonplaten deleted the disable_flax_gpu_tests branch February 3, 2022 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants