Skip to content

Conversation

@sgugger
Copy link
Collaborator

@sgugger sgugger commented Mar 17, 2022

What does this PR do?

This PR removes the need for a full dev installed when a user wants to run add-new-model-like.

@sgugger sgugger requested a review from LysandreJik March 17, 2022 19:40
@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Mar 17, 2022

The documentation is not available anymore as the PR was closed or merged.

Copy link
Member

@LysandreJik LysandreJik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks for working on it @sgugger!

@LysandreJik LysandreJik merged commit 0a5ef03 into master Mar 21, 2022
@LysandreJik LysandreJik deleted the add_new_model_like_framework branch March 21, 2022 08:29
FrancescoSaverioZuppichini pushed a commit that referenced this pull request Mar 24, 2022
* Make add-new-model-like work without all frameworks installed

* A few fixes

* Last default frameworks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants