Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added type hints for BART model #16270

Merged
merged 5 commits into from Mar 21, 2022
Merged

added type hints for BART model #16270

merged 5 commits into from Mar 21, 2022

Conversation

robotjellyzone
Copy link
Contributor

@robotjellyzone robotjellyzone commented Mar 19, 2022

What does this PR do?

I have added type hints for BART model (both in PyTorch and Tensorflow) as described in #16059

@Rocketknight1

@robotjellyzone
Copy link
Contributor Author

@Rocketknight1 here is the PR which i've created since i am on Windows so i didnt run make fixup command

@Rocketknight1
Copy link
Member

Hi @robotjellyzone, thanks for the PR! I see a lot of tests failing but I think that's our fault, not yours. Let me try running make fixup and then rerun them, and hopefully it all passes

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Mar 21, 2022

The documentation is not available anymore as the PR was closed or merged.

@Rocketknight1
Copy link
Member

@robotjellyzone Tests pass now! Will merge and then update the other PRs depending on these copied models.

@Rocketknight1 Rocketknight1 merged commit d50f62f into huggingface:master Mar 21, 2022
FrancescoSaverioZuppichini pushed a commit that referenced this pull request Mar 24, 2022
* added type hints for BART model

* make fixup, adding imports to copied files

* Adding some missing types to cookiecutter

* Adding some missing types to cookiecutter

* Adding some missing types to cookiecutter

Co-authored-by: matt <rocketknight1@gmail.com>
@robotjellyzone robotjellyzone deleted the type_hints branch April 20, 2022 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants