Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add table transformer [v2] #19614

Merged
merged 14 commits into from
Oct 18, 2022
Merged

Add table transformer [v2] #19614

merged 14 commits into from
Oct 18, 2022

Conversation

NielsRogge
Copy link
Contributor

@NielsRogge NielsRogge commented Oct 14, 2022 •
edited
Loading

What does this PR do?

This PR adds Table Transformer by Microsoft, as a separate model, rather than tweaking the existing DETR implementation.

@NielsRogge NielsRogge mentioned this pull request Oct 14, 2022
Closed
2 tasks
@NielsRogge NielsRogge force-pushed the add_table_transformer_v2 branch from 95222cd to 6a6665d Compare October 14, 2022 09:49
@NielsRogge NielsRogge requested a review from sgugger October 14, 2022 09:49
sgugger
sgugger reviewed Oct 14, 2022
View reviewed changes
Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for adding this new model!

New model additions are very big PRs on their own, so let's remove the non-related stuff in another PR please.

docs/source/en/_toctree.yml Outdated Show resolved Hide resolved
docs/source/en/model_doc/deformable_detr.mdx Outdated Show resolved Hide resolved
src/transformers/models/conditional_detr/modeling_conditional_detr.py Outdated Show resolved Hide resolved
src/transformers/models/detr/modeling_detr.py Outdated Show resolved Hide resolved
src/transformers/models/table_transformer/configuration_table_transformer.py Show resolved Hide resolved
@NielsRogge
Copy link
Contributor Author

NielsRogge commented Oct 17, 2022 •
edited
Loading

@sgugger I've removed the non-Table Transformer related stuff to #19644 ;)

@NielsRogge NielsRogge force-pushed the add_table_transformer_v2 branch from 6f3294c to 1fdb60d Compare October 17, 2022 12:39
@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Oct 17, 2022 •
edited
Loading

The documentation is not available anymore as the PR was closed or merged.

@NielsRogge
Copy link
Contributor Author

@sgugger PR is ready, feel free to approve :)

sgugger
sgugger approved these changes Oct 17, 2022
View reviewed changes
Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again for working on this model!

@NielsRogge NielsRogge force-pushed the add_table_transformer_v2 branch from 1fdb60d to 496f9eb Compare October 18, 2022 10:12
@NielsRogge NielsRogge merged commit dd523da into huggingface:main Oct 18, 2022
@antew antew mentioned this pull request Dec 13, 2022
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgugger sgugger sgugger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@NielsRogge @HuggingFaceDocBuilderDev @sgugger