Support ratios for logging_steps, eval_steps, and save_steps - #23235
Merged
sgugger merged 10 commits intoMay 9, 2023
Conversation
sgugger
reviewed
May 9, 2023
sgugger
left a comment
sgugger
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for your PR! I have a couple of comments, but it's in great shape already!
Comment on lines
+1216
to
+1221
| if ( | ||
| self.logging_strategy == IntervalStrategy.STEPS | ||
| and self.logging_steps > 1 | ||
| and self.logging_steps != int(self.logging_steps) | ||
| ): | ||
| raise ValueError(f"--logging_steps must be an integer if bigger than 1: {self.logging_steps}") |
Collaborator
There was a problem hiding this comment.
Maybe here also convert the logging_steps to ints when they are bigger than 1 (same below for the two others).
|
The documentation is not available anymore as the PR was closed or merged. |
Co-authored-by: Sylvain Gugger <35901082+sgugger@users.noreply.github.com>
Co-authored-by: Sylvain Gugger <35901082+sgugger@users.noreply.github.com>
Co-authored-by: Sylvain Gugger <35901082+sgugger@users.noreply.github.com>
…r/transformers into log-eval-save-arg-ratio
gojiteji
pushed a commit
to gojiteji/transformers
that referenced
this pull request
Jun 5, 2023
…uggingface#23235) * Ratio option for `logging_steps`, `eval_steps`, `save_steps` * Add guards if arguments are not set * Add more detailed comments + formatting * Update src/transformers/training_args.py Co-authored-by: Sylvain Gugger <35901082+sgugger@users.noreply.github.com> * Update src/transformers/training_args.py Co-authored-by: Sylvain Gugger <35901082+sgugger@users.noreply.github.com> * Update src/transformers/training_args.py Co-authored-by: Sylvain Gugger <35901082+sgugger@users.noreply.github.com> * Convert args values to `int` if bigger than 1 * `black` * `make fixup` --------- Co-authored-by: Sylvain Gugger <35901082+sgugger@users.noreply.github.com>
novice03
pushed a commit
to novice03/transformers
that referenced
this pull request
Jun 23, 2023
…uggingface#23235) * Ratio option for `logging_steps`, `eval_steps`, `save_steps` * Add guards if arguments are not set * Add more detailed comments + formatting * Update src/transformers/training_args.py Co-authored-by: Sylvain Gugger <35901082+sgugger@users.noreply.github.com> * Update src/transformers/training_args.py Co-authored-by: Sylvain Gugger <35901082+sgugger@users.noreply.github.com> * Update src/transformers/training_args.py Co-authored-by: Sylvain Gugger <35901082+sgugger@users.noreply.github.com> * Convert args values to `int` if bigger than 1 * `black` * `make fixup` --------- Co-authored-by: Sylvain Gugger <35901082+sgugger@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #23171
Adds support for ratios to the
logging_steps,eval_steps, andsave_stepsarguments, i.e. if they are a float in range[0,1), the steps are calculated as a ratio of total training steps.Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
@sgugger