From 3b71b049441c5f536e14fa268e658e27cbd0dafc Mon Sep 17 00:00:00 2001 From: ydshieh Date: Wed, 3 Sep 2025 10:41:00 +0200 Subject: [PATCH 1/3] fix --- tests/generation/test_utils.py | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tests/generation/test_utils.py b/tests/generation/test_utils.py index 69c1e0f6674c..e05359caeb8f 100644 --- a/tests/generation/test_utils.py +++ b/tests/generation/test_utils.py @@ -796,6 +796,8 @@ def test_prompt_lookup_decoding_matches_greedy_search(self): "chameleon", "internvl", "qwen2_5omni", # the file is named `qwen2_5_omni`, but the model class is `Qwen2_5Omni`, + # All models below: shouldn't suggest audio tokens. Can be fixed by passing `suppress_ids` to candidate generator: @joaa @raushan + "voxtral", ] ): self.skipTest(reason="May fix in the future: need model-specific fixes") From 8975419ffedf46b60c5afcf973ae1358006dde30 Mon Sep 17 00:00:00 2001 From: ydshieh Date: Wed, 3 Sep 2025 10:57:34 +0200 Subject: [PATCH 2/3] fix --- tests/generation/test_utils.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/generation/test_utils.py b/tests/generation/test_utils.py index e05359caeb8f..e436f67f58f7 100644 --- a/tests/generation/test_utils.py +++ b/tests/generation/test_utils.py @@ -797,7 +797,7 @@ def test_prompt_lookup_decoding_matches_greedy_search(self): "internvl", "qwen2_5omni", # the file is named `qwen2_5_omni`, but the model class is `Qwen2_5Omni`, # All models below: shouldn't suggest audio tokens. Can be fixed by passing `suppress_ids` to candidate generator: @joaa @raushan - "voxtral", + "voxtral", ] ): self.skipTest(reason="May fix in the future: need model-specific fixes") From 714377eb60f656515fa432dff04c62f642fbd880 Mon Sep 17 00:00:00 2001 From: ydshieh Date: Wed, 3 Sep 2025 13:36:09 +0200 Subject: [PATCH 3/3] fix --- tests/generation/test_utils.py | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/generation/test_utils.py b/tests/generation/test_utils.py index e436f67f58f7..f285ce2818bf 100644 --- a/tests/generation/test_utils.py +++ b/tests/generation/test_utils.py @@ -779,6 +779,7 @@ def test_prompt_lookup_decoding_matches_greedy_search(self): "blip2", # overridden `generate()` for all BLIP models "instructblip", "instructblipvideo", + # TODO: The list is growing huge 🙃! Let's try to check if the config has any of audio/image/video token id and skip the test! # All models below: shouldn't suggest image tokens. Can be fixed by passing `suppress_ids` to candidate generator: @joaa @raushan "llava", "idefics2",