Skip to content

Stop inheriting tests! #42192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 14, 2025
Merged

Stop inheriting tests! #42192

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6781ef2
Stop inheriting tests!
Rocketknight1 Nov 13, 2025
2d16319
Just use a del instead
Rocketknight1 Nov 14, 2025
1d55cc4
fixup
Rocketknight1 Nov 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions tests/models/cohere2/test_modeling_cohere2.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -269,3 +269,6 @@ def test_generation_beyond_sliding_window(self, attn_implementation: str):
output_text = tokenizer.batch_decode(out)

self.assertEqual(output_text, EXPECTED_COMPLETIONS)


del CohereModelTest, CohereModelTester # So the parent tests don't run in this file too
3 changes: 3 additions & 0 deletions tests/models/granitemoehybrid/test_modeling_granitemoehybrid.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,3 +178,6 @@ def test_model_generation(self):
text = tokenizer.decode(generated_ids[0], skip_special_tokens=True)

self.assertEqual(EXPECTED_TEXT_COMPLETION, text)


del BambaModelTest, BambaModelTester # So the parent tests don't run in this file too