New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HG2: modified RC-RegExp after API-Output changed #4

Merged
merged 2 commits into from Feb 9, 2014

Conversation

Projects
None yet
2 participants
@se4598
Member

se4598 commented Feb 8, 2014

The order of the properties in a rc-line of the API-Output changed from ... "rcid", "pageid", "revid", "old_revid" ... to ... "pageid", "revid", "old_revid", "rcid" ... thus failing on the RegExp and the matching groups and consequently displaying any edits in the queues (unless IRC-Feed is used), making huggle useless

This was probably caused by https://gerrit.wikimedia.org/r/107389

So this change modifies the RC-RegExp and the matching group-numbers.

Also I changed NewBlock.Admin, NewDelete.Admin and NewProtection.Admin value from matching group "old_revid" to "user" (if I counted correctly)

Second commit is a nice to have:
detect IPv6 edits as anonymous (but without IP-range support)

se4598 added some commits Feb 8, 2014

modified RC-RegExp after API-Output changed
The order of the properties in a rc-line of the API-Output changed from ... "rcid", "pageid", "revid", "old_revid" ... to ... "pageid", "revid", "old_revid", "rcid" ... thus failing on the RegExp and the matching groups.
(this was probably caused by https://gerrit.wikimedia.org/r/107389 )

So this change modifies the RC-RegExp and the matching group-numbers.

Also I changed NewBlock.Admin, NewDelete.Admin and NewProtection.Admin value from matching group "old_revid" to "user" (if I counted correctly)
@benapetr

This comment has been minimized.

Show comment
Hide comment
@benapetr

benapetr Feb 9, 2014

Member

let me first discuss this with others, if IRC items really were reordered, it's a bug in mediawiki that needs to be rolled back so that they are same as before. There is no point in changing their order.

Member

benapetr commented Feb 9, 2014

let me first discuss this with others, if IRC items really were reordered, it's a bug in mediawiki that needs to be rolled back so that they are same as before. There is no point in changing their order.

@se4598

This comment has been minimized.

Show comment
Hide comment
@se4598

se4598 Feb 9, 2014

Member

No, the alternative IRC-Feed is still working.
The XML-Output of the API-Request if you don't use IRC, changed because the order of the addition of the properties changed.

I think it's not a bug in mediawiki. It's the unflexibility of huggle, because we parse XML(!) with this RegExp, which heavily relies on the ordering(!!) and (not) presence of attributes. I don't think that XML is expected to be parsed in this way.
(see also the responses at https://en.wikipedia.org/wiki/User_talk:Anomie#WP:Huggle )

Member

se4598 commented Feb 9, 2014

No, the alternative IRC-Feed is still working.
The XML-Output of the API-Request if you don't use IRC, changed because the order of the addition of the properties changed.

I think it's not a bug in mediawiki. It's the unflexibility of huggle, because we parse XML(!) with this RegExp, which heavily relies on the ordering(!!) and (not) presence of attributes. I don't think that XML is expected to be parsed in this way.
(see also the responses at https://en.wikipedia.org/wiki/User_talk:Anomie#WP:Huggle )

@benapetr

This comment has been minimized.

Show comment
Hide comment
@benapetr

benapetr Feb 9, 2014

Member

Yes I agree that this way of parsing xml suck, huggle 3 does it correctly though

Member

benapetr commented Feb 9, 2014

Yes I agree that this way of parsing xml suck, huggle 3 does it correctly though

benapetr added a commit that referenced this pull request Feb 9, 2014

Merge pull request #4 from se4598/master
HG2: modified RC-RegExp after API-Output changed

@benapetr benapetr merged commit 1be6872 into huggle:master Feb 9, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment