New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No Application icon on Mac OS #26

Closed
legoktm opened this Issue Oct 27, 2013 · 6 comments

Comments

Projects
None yet
5 participants
@legoktm
Contributor

legoktm commented Oct 27, 2013

Unsure if this is an OSX specific issue, but after I built huggle, the huggle.app file used the standard "A" app icon thing rather than a custom one.

@theopolisme

This comment has been minimized.

Show comment
Hide comment
@theopolisme

theopolisme commented Oct 31, 2013

An icon has to be defined in an info.plist file for it to appear.
More info: http://stackoverflow.com/questions/646671/how-do-i-set-the-icon-for-my-applications-mac-os-x-app-bundle

@benapetr

This comment has been minimized.

Show comment
Hide comment
@benapetr

benapetr Feb 21, 2014

Member

Is this really an issue in huggle? I think that proper packaging is a solution here and that has nothing to do with source code.

Member

benapetr commented Feb 21, 2014

Is this really an issue in huggle? I think that proper packaging is a solution here and that has nothing to do with source code.

@benapetr benapetr closed this Feb 21, 2014

@legoktm

This comment has been minimized.

Show comment
Hide comment
@legoktm

legoktm Feb 21, 2014

Contributor

Uhhh, how is it not an issue in huggle?

Contributor

legoktm commented Feb 21, 2014

Uhhh, how is it not an issue in huggle?

@benapetr

This comment has been minimized.

Show comment
Hide comment
@benapetr

benapetr Feb 21, 2014

Member

Because this is packaging issue, nothing wrong in source code etc. There is
no huggle installer or package for osx, when someone finally create some,
they will probably include that file which defines the icon. But this
requires someone with osx to create the package. There is nothing wrong
with huggle itself.

On Fri, Feb 21, 2014 at 9:45 PM, Kunal Mehta notifications@github.comwrote:

Uhhh, how is it not an issue in huggle?

Reply to this email directly or view it on GitHubhttps://github.com//issues/26#issuecomment-35771652
.

Member

benapetr commented Feb 21, 2014

Because this is packaging issue, nothing wrong in source code etc. There is
no huggle installer or package for osx, when someone finally create some,
they will probably include that file which defines the icon. But this
requires someone with osx to create the package. There is nothing wrong
with huggle itself.

On Fri, Feb 21, 2014 at 9:45 PM, Kunal Mehta notifications@github.comwrote:

Uhhh, how is it not an issue in huggle?

Reply to this email directly or view it on GitHubhttps://github.com//issues/26#issuecomment-35771652
.

@Matthewrbowker

This comment has been minimized.

Show comment
Hide comment
@Matthewrbowker

Matthewrbowker Feb 22, 2014

Contributor

Actually, it appears to have to be defined before "make" is run on OSX: https://stackoverflow.com/questions/21027988/how-to-set-the-application-icon-in-a-qt-application-on-os-x-sufficient-for-dist As the ".pro" file is part of the source code, it would make sense that is is a huggle issue. The problem is acquiring a proper icns file. I'm going to re-open this issue and assign it to myself, I'll take care of it because I have a mac.

Contributor

Matthewrbowker commented Feb 22, 2014

Actually, it appears to have to be defined before "make" is run on OSX: https://stackoverflow.com/questions/21027988/how-to-set-the-application-icon-in-a-qt-application-on-os-x-sufficient-for-dist As the ".pro" file is part of the source code, it would make sense that is is a huggle issue. The problem is acquiring a proper icns file. I'm going to re-open this issue and assign it to myself, I'll take care of it because I have a mac.

@Matthewrbowker Matthewrbowker self-assigned this Feb 22, 2014

@josve05a

This comment has been minimized.

Show comment
Hide comment
@josve05a

josve05a Apr 2, 2014

Contributor

(This might be unrelated but...) The pre-built packages for HG3 for Windows doesn't have an icon either.

Contributor

josve05a commented Apr 2, 2014

(This might be unrelated but...) The pre-built packages for HG3 for Windows doesn't have an icon either.

Matthewrbowker added a commit that referenced this issue Apr 14, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment