New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit form problems #294

Open
AbelmoschusEsculentus opened this Issue Jul 13, 2018 · 8 comments

Comments

Projects
None yet
2 participants
@AbelmoschusEsculentus
Contributor

AbelmoschusEsculentus commented Jul 13, 2018

  1. I checked the minor edit button, but the edit is not marked as minor.
  2. Times font is not so suitable for the preview. (from what I've seen)
  3. Preview box is a bit small
  4. Font size of preview box should be shrunk
  5. Photos and media are not rendered in the preview (only the outline)
  6. The "edit source" beside headings in the preview box is a bit annoying
  7. Red links are not shown in the preview box
  8. When I copy and paste formatted text to the edit box, the font size of the copied text will not be same as others.
    Thanks for reading
@benapetr

This comment has been minimized.

Show comment
Hide comment
@benapetr

benapetr Jul 30, 2018

Member

1: fixed
2: fixed
3: you can resize it
4:what is shunk?

6, 7 is probably something to be fixed on MW API level

8 fixed

Member

benapetr commented Jul 30, 2018

1: fixed
2: fixed
3: you can resize it
4:what is shunk?

6, 7 is probably something to be fixed on MW API level

8 fixed

@AbelmoschusEsculentus

This comment has been minimized.

Show comment
Hide comment
@AbelmoschusEsculentus

AbelmoschusEsculentus Jul 31, 2018

Contributor

Oops that’s a typo. Shrunk is the past participle of shrink

Contributor

AbelmoschusEsculentus commented Jul 31, 2018

Oops that’s a typo. Shrunk is the past participle of shrink

@AbelmoschusEsculentus

This comment has been minimized.

Show comment
Hide comment
@AbelmoschusEsculentus

AbelmoschusEsculentus Aug 4, 2018

Contributor

I am using Qt5.11.1 currently. The preview box of edit form and report user form is WAY too small.
screen shot 2018-08-04 at 20 01 06
screen shot 2018-08-04 at 20 00 54

Contributor

AbelmoschusEsculentus commented Aug 4, 2018

I am using Qt5.11.1 currently. The preview box of edit form and report user form is WAY too small.
screen shot 2018-08-04 at 20 01 06
screen shot 2018-08-04 at 20 00 54

@benapetr

This comment has been minimized.

Show comment
Hide comment
@benapetr

benapetr Aug 4, 2018

Member

idk why u see it this way, should be fixed in last version

Member

benapetr commented Aug 4, 2018

idk why u see it this way, should be fixed in last version

@AbelmoschusEsculentus

This comment has been minimized.

Show comment
Hide comment
@AbelmoschusEsculentus

AbelmoschusEsculentus Aug 5, 2018

Contributor

Still looking weird (only in Edit form, report form is ok)
Here is a little video: Demo.zip
I think the problem is the splitter is put between the edit box (textEdit) and "preview" (label_2), not edit box and "preview"+preview box (I think the preview box is generated afterwards?). That means "preview" (label_2) needs to group with the preview box. Am I correct?

Contributor

AbelmoschusEsculentus commented Aug 5, 2018

Still looking weird (only in Edit form, report form is ok)
Here is a little video: Demo.zip
I think the problem is the splitter is put between the edit box (textEdit) and "preview" (label_2), not edit box and "preview"+preview box (I think the preview box is generated afterwards?). That means "preview" (label_2) needs to group with the preview box. Am I correct?

@benapetr

This comment has been minimized.

Show comment
Hide comment
@benapetr

benapetr Aug 5, 2018

Member

it doesn't happen to me, no idea why, try if this helps: f434102

Other thing that would definitely help is setting a constrain on max vsize but that could break this on HD displays as they would need way more pixels to display regular size font.

Member

benapetr commented Aug 5, 2018

it doesn't happen to me, no idea why, try if this helps: f434102

Other thing that would definitely help is setting a constrain on max vsize but that could break this on HD displays as they would need way more pixels to display regular size font.

@AbelmoschusEsculentus

This comment has been minimized.

Show comment
Hide comment
@AbelmoschusEsculentus

AbelmoschusEsculentus Aug 5, 2018

Contributor

Just tried your latest commit. Didn't work :(

I have a 13.3 inch 1440x900 screen btw

Which Qt version you are using?

Contributor

AbelmoschusEsculentus commented Aug 5, 2018

Just tried your latest commit. Didn't work :(

I have a 13.3 inch 1440x900 screen btw

Which Qt version you are using?

@AbelmoschusEsculentus

This comment has been minimized.

Show comment
Hide comment
@AbelmoschusEsculentus

AbelmoschusEsculentus Aug 5, 2018

Contributor

Oh I tried to use Qt5.10.1 and it's fixed.

Contributor

AbelmoschusEsculentus commented Aug 5, 2018

Oh I tried to use Qt5.10.1 and it's fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment