Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modernize the validation requirements #296

Merged
merged 1 commit into from Mar 20, 2019

Conversation

Projects
None yet
2 participants
@hughsie
Copy link
Owner

hughsie commented Mar 20, 2019

  • Require <content_rating> for any desktop or console application
  • Make mandatory when validating
  • Further relax style requirements
  • Require description for desktop an console apps

This changes a lot of things that are now best practice for all apps, and
required to be included in Flathub.

Use appstream-util validate-relax to ignore some new failures and use
appstream-util validate-strict to bring them back.

Fixes: #263

@hughsie hughsie added the enhancement label Mar 20, 2019

@hughsie hughsie self-assigned this Mar 20, 2019

@hughsie hughsie requested a review from kalev Mar 20, 2019

@kalev

kalev approved these changes Mar 20, 2019

Copy link
Collaborator

kalev left a comment

Looks good to me! Just two minor nits I noticed.

Show resolved Hide resolved libappstream-glib/as-app-validate.c Outdated
Show resolved Hide resolved libappstream-glib/as-self-test.c Outdated
Modernize the validation requirements
 * Require <content_rating> for any desktop or console application
 * Make <release> mandatory when validating
 * Further relax style requirements
 * Require description for desktop an console apps

This changes a lot of things that are now best practice for all apps, and
required to be included in Flathub.

Use `appstream-util validate-relax` to ignore some new failures and use
`appstream-util validate-strict` to bring them back.

Fixes: #263

@hughsie hughsie force-pushed the wip/hughsie/flathub-validation branch from fb0d84c to 9237d19 Mar 20, 2019

@hughsie hughsie merged commit 2eb9b8c into master Mar 20, 2019

0 of 4 checks passed

LGTM analysis: C/C++ Fetching git commits
Details
LGTM analysis: JavaScript Fetching git commits
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details

@hughsie hughsie deleted the wip/hughsie/flathub-validation branch Mar 20, 2019

gnomesysadmins pushed a commit to GNOME/gnome-weather that referenced this pull request Mar 28, 2019

appdata: add releases section
After hughsie/appstream-glib#296,
a releases section is required in order to pass validation.

gnomesysadmins pushed a commit to GNOME/gnome-boxes that referenced this pull request Mar 29, 2019

appdata: Add "release" tag
The appdata validation is now more strict, and requires the addition
of the <release> tag.

Lets ship the 3.32.0.2 release notes for now.

See hughsie/appstream-glib#296

gnomesysadmins pushed a commit to GNOME/gnome-photos that referenced this pull request Apr 1, 2019

appdata: Add release tag
The appdata validation is now more strict and now has a
mandatory requirement of the "release" tag [1]

[1] hughsie/appstream-glib#296

gnomesysadmins pushed a commit to GNOME/totem that referenced this pull request Apr 1, 2019

appdata: Add "release" tag
The appdata validation is now more strict and has a
mandatory requirement of the "release" tag [1]

[1] hughsie/appstream-glib#296

gnomesysadmins pushed a commit to GNOME/gnome-photos that referenced this pull request Apr 1, 2019

appdata: Add release tag
The appdata validation is now more strict and has a
mandatory requirement of the "release" tag [1]

[1] hughsie/appstream-glib#296

gnomesysadmins pushed a commit to GNOME/totem that referenced this pull request Apr 1, 2019

appdata: Add "release" tag
The appdata validation is now more strict and has a
mandatory requirement of the "release" tag [1]

[1] hughsie/appstream-glib#296

gnomesysadmins pushed a commit to GNOME/gnome-documents that referenced this pull request Apr 1, 2019

appdata: Add release tag
The appdata validation is now more strict and has a
mandatory requirement of the "release" tag [1]

[1] hughsie/appstream-glib#296

gnomesysadmins pushed a commit to GNOME/gnome-usage that referenced this pull request Apr 2, 2019

appdata: Add <release> tag
The appdata validation is now more strict, and requires the addition
of the <release> tag.

See hughsie/appstream-glib#296

gnomesysadmins pushed a commit to GNOME/totem that referenced this pull request Apr 3, 2019

appdata: Add "release" tag
The appdata validation is now more strict and has a
mandatory requirement of the "release" tag [1]

[1] hughsie/appstream-glib#296
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.