New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wip/hughsie/atmel flip #292

Merged
merged 10 commits into from Oct 31, 2017

Conversation

2 participants
@hughsie
Owner

hughsie commented Oct 27, 2017

No description provided.

@hughsie hughsie requested review from gicmo and superm1 Oct 27, 2017

DfuTargetTransferFlags flags,
GCancellable *cancellable,
GError **error);
};

This comment has been minimized.

@superm1

superm1 Oct 27, 2017

Collaborator

This may not be a large issue, and intended but i'll mention in case it's an oversight.
You previously had padding for 8 reservations but only added 6 function assignments.

@superm1

superm1 Oct 27, 2017

Collaborator

This may not be a large issue, and intended but i'll mention in case it's an oversight.
You previously had padding for 8 reservations but only added 6 function assignments.

This comment has been minimized.

@hughsie

hughsie Oct 27, 2017

Owner

Good point, but I removed the padding as we're not installing the library I don't care about ABI much. If you're more comfortable I can remove all the class padding in a separate commit.

@hughsie

hughsie Oct 27, 2017

Owner

Good point, but I removed the padding as we're not installing the library I don't care about ABI much. If you're more comfortable I can remove all the class padding in a separate commit.

This comment has been minimized.

@superm1

superm1 Oct 27, 2017

Collaborator

No worry, I think it's fine as is. just wanted to make sure you were aware. Since it's internal private ABI probably not a big deal.

@superm1

superm1 Oct 27, 2017

Collaborator

No worry, I think it's fine as is. just wanted to make sure you were aware. Since it's internal private ABI probably not a big deal.

This comment has been minimized.

@hughsie

hughsie Oct 28, 2017

Owner

I've removed this manually in master.

@hughsie

hughsie Oct 28, 2017

Owner

I've removed this manually in master.

@@ -689,6 +710,10 @@ dfu_device_set_quirks (DfuDevice *device)
}
}
/* Atmel bootloader */
if (vid == 0x03eb)

This comment has been minimized.

@superm1

superm1 Oct 27, 2017

Collaborator

It would be good to put this into a #define for the vendor instead of comment.

@superm1

superm1 Oct 27, 2017

Collaborator

It would be good to put this into a #define for the vendor instead of comment.

This comment has been minimized.

@hughsie

hughsie Oct 28, 2017

Owner

I've avoided this in the set_quirks() function as we only need it once, and I'm not sure it adds to the readability.

@hughsie

hughsie Oct 28, 2017

Owner

I've avoided this in the set_quirks() function as we only need it once, and I'm not sure it adds to the readability.

This comment has been minimized.

@superm1

superm1 Oct 30, 2017

Collaborator

Well maybe not now, but i was thinking if the quirks grows a lot then it would make it more readable later to do it that way.

@superm1

superm1 Oct 30, 2017

Collaborator

Well maybe not now, but i was thinking if the quirks grows a lot then it would make it more readable later to do it that way.

This comment has been minimized.

@hughsie

hughsie Oct 30, 2017

Owner

I think this is solved by #293 :)

@hughsie

hughsie Oct 30, 2017

Owner

I think this is solved by #293 :)

This comment has been minimized.

@superm1

superm1 Oct 30, 2017

Collaborator

True :)

@superm1

superm1 Oct 30, 2017

Collaborator

True :)

Show outdated Hide outdated plugins/dfu/dfu-target-stm.c Outdated
Show outdated Hide outdated plugins/dfu/dfu-common.h Outdated

@hughsie hughsie referenced this pull request Oct 28, 2017

Closed

Add AVR/Atmel DFU support #128

hughsie added some commits Oct 27, 2017

dfu: Add support for a chip ID
This allows us to show the user something they can include in a bug report.
dfu: Ignore the not-supported error code when opening the DfuDevice
This allows us to fail optional things and still show useful output in:

$ dfu-tool list
dfu: Set up the DfuTarget when opening the DfuDevice
In the future we'll use this to set vendor-specific quirks.
dfu: Add DfuChunked
This allows us to segment a buffer taking into account page borders and maximum
transfer sizes.
@hughsie

This comment has been minimized.

Show comment
Hide comment
@hughsie

hughsie Oct 30, 2017

Owner

I've added two more commits, if those look good I think we can merge this.

Owner

hughsie commented Oct 30, 2017

I've added two more commits, if those look good I think we can merge this.

hughsie added some commits Oct 26, 2017

dfu: Add support for one type of AVR32 device
Currently the only supported model is the AT32UC3A3256S, more to come...
dfu: Remove the CanDownload and CanUpload attribute when required
When the AVR device is not recognised as a supported part we can't read or
write the firmware from the chip.
dfu: Allow specifying the output file type for 'dfu-tool read'
Guess the file type if it is not explicitly specified.
dfu: Correctly output Intel HEX files with > 16bit offset addresses
Also, fix the checksum to actually produce valid files...
@superm1

LGTM

@hughsie hughsie merged commit 78c1e6c into master Oct 31, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@hughsie hughsie deleted the wip/hughsie/atmel-flip branch Oct 31, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment