New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rts54xx: Add a plugin to update a Realtek USB hub #685

Merged
merged 1 commit into from Sep 14, 2018

Conversation

3 participants
@hughsie
Owner

hughsie commented Aug 24, 2018

No description provided.

@hughsie hughsie added the enhancement label Aug 24, 2018

@hughsie hughsie self-assigned this Aug 24, 2018

@AnyProblem

I am Ricky_wu, thank your for your help!

@hughsie

This comment has been minimized.

Show comment
Hide comment
@hughsie

hughsie Sep 11, 2018

Owner

@superm1 I flashed the RTS development board using the rts54hub plugin; I'm thinking on merging this now we know it works. I'm tempted to leave the HID version out until we have an actual product that can use it, but on the other hand it's going to be useful as reference code for any vendor using the non-HUB mode, and if it's not merged it's just going to bitrot. Ideas welcome.

Owner

hughsie commented Sep 11, 2018

@superm1 I flashed the RTS development board using the rts54hub plugin; I'm thinking on merging this now we know it works. I'm tempted to leave the HID version out until we have an actual product that can use it, but on the other hand it's going to be useful as reference code for any vendor using the non-HUB mode, and if it's not merged it's just going to bitrot. Ideas welcome.

@superm1

This comment has been minimized.

Show comment
Hide comment
@superm1

superm1 Sep 11, 2018

Collaborator

Since you're implementing both flashing protocols (over HUB or over HID) I think it may be relevant to show some sort of device link between the HID and HUB device and which endpoint should typically be used for flashing. In practice I don't think most devices should be able to flash over both protocols when shipping (reference boards and reference FW implementation probably will though). This might be fine to just use with quirks and an updatable flag, just want to make sure you've considered it before backing yourself into a corner.

Collaborator

superm1 commented Sep 11, 2018

Since you're implementing both flashing protocols (over HUB or over HID) I think it may be relevant to show some sort of device link between the HID and HUB device and which endpoint should typically be used for flashing. In practice I don't think most devices should be able to flash over both protocols when shipping (reference boards and reference FW implementation probably will though). This might be fine to just use with quirks and an updatable flag, just want to make sure you've considered it before backing yourself into a corner.

@hughsie

This comment has been minimized.

Show comment
Hide comment
@hughsie

hughsie Sep 11, 2018

Owner

some sort of device link between the HID and HUB device

I has kinda hoped that the VID/PID would be different on models doing different flashing protocols.

Owner

hughsie commented Sep 11, 2018

some sort of device link between the HID and HUB device

I has kinda hoped that the VID/PID would be different on models doing different flashing protocols.

@superm1

This comment has been minimized.

Show comment
Hide comment
@superm1

superm1 Sep 11, 2018

Collaborator

I has kinda hoped that the VID/PID would be different on models doing different flashing protocols.

I hope so too, but I don't know if that's a guarantee or not.

Collaborator

superm1 commented Sep 11, 2018

I has kinda hoped that the VID/PID would be different on models doing different flashing protocols.

I hope so too, but I don't know if that's a guarantee or not.

@hughsie

This comment has been minimized.

Show comment
Hide comment
@hughsie

hughsie Sep 12, 2018

Owner

I've cut out the hub bits, now those are in master and left the bare-bones HID example.

Owner

hughsie commented Sep 12, 2018

I've cut out the hub bits, now those are in master and left the bare-bones HID example.

@superm1

This comment has been minimized.

Show comment
Hide comment
@superm1

superm1 Sep 13, 2018

Collaborator

LGTM after removing those status bytes.

Collaborator

superm1 commented Sep 13, 2018

LGTM after removing those status bytes.

@hughsie hughsie merged commit 35a0a45 into master Sep 14, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@hughsie hughsie deleted the wip/hughsie/realtek branch Sep 14, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment