Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export the old JCatEngine property to preserve internal ABI #40

Merged
merged 1 commit into from
Jun 26, 2020

Conversation

hughsie
Copy link
Owner

@hughsie hughsie commented Jun 26, 2020

@hughsie hughsie added the bug Something isn't working label Jun 26, 2020
@hughsie hughsie requested a review from superm1 June 26, 2020 12:41
@hughsie hughsie self-assigned this Jun 26, 2020
@superm1
Copy link
Collaborator

superm1 commented Jun 26, 2020

LGTM

@hughsie
Copy link
Owner Author

hughsie commented Jun 26, 2020

Hah, so I double checked for sanity:

<hughsie> ebassi, GLib question if i may. Is it okay to do something like:
<hughsie>  g_object_class_install_property (object_class, PROP_METHOD, g_param_spec_uint ("one", NULL, NULL, 0, 1, 0, G_PARAM_READWRITE));
<hughsie>  g_object_class_install_property (object_class, PROP_METHOD, g_param_spec_uint ("two", NULL, NULL, 0, 1, 0, G_PARAM_READABLE));
<ebassi> Nope
<ebassi> Unless you want to overwrite "one" with "two"

@hughsie hughsie marked this pull request as ready for review June 26, 2020 15:15
@hughsie hughsie merged commit 2278866 into master Jun 26, 2020
@hughsie hughsie deleted the wip/hughsie/GObjectABI branch June 26, 2020 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

lvfs-testing: no signature method in results
2 participants