fix: chrome not exiting cleanly #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chrome sometimes doesn’t exit cleanly: https://code.google.com/p/chromium/issues/detail?id=338000 This takes a brute-force approach to making sure that we really do exit when required. Fixes hughsk/smokestack#44
hughsk
added a commit
that referenced
this pull request
Aug 27, 2015
fix: chrome not exiting cleanly
|
❤️ so sorry this took so long for me to merge. Thanks very much! |
|
hi, this isn't a good fix as it pretty much renders chrome-launch unusable as a library. I have some code which launches chrome, does some stuff then closes it. My code continues execution and then launches chrome again. Sometime around here this fix kicks in and calls I've not looked into the details of how to fix this properly - but |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Chrome sometimes doesn’t exit cleanly: https://code.google.com/p/chromium/issues/detail?id=338000
This takes a brute-force approach to making sure that we really do exit when required.
Fixes hughsk/smokestack#44
There's one test failing right now.
chrome-launch: process.exit. I'm not totally sure if that's just an invalid test now, or a problem that needs to be addressed.