Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix prototype pollution in unflatten #106

Merged
merged 2 commits into from
Aug 6, 2020
Merged

Fix prototype pollution in unflatten #106

merged 2 commits into from
Aug 6, 2020

Conversation

MatthiasKunnen
Copy link
Contributor

@MatthiasKunnen MatthiasKunnen commented Jul 21, 2020

The unflatten function contains a prototype pollution vulnerability. I've added a test and fix.

I've tested back to 1.0.0 and all versions are vulnerable.

This fixes #105 .

@deleonio
Copy link

deleonio commented Aug 3, 2020

Hello, ist that possible to merge in all releases. The major release ...

1.6.1
2.0.0
3.0.0
4.1.0
5.0.0

@timoxley timoxley merged commit 20ef0ef into hughsk:master Aug 6, 2020
@timoxley
Copy link
Contributor

timoxley commented Aug 6, 2020

Backported fix and released new major versions:

  • 1.6.2
  • 2.0.2
  • 3.0.1
  • 4.1.2
  • 5.0.2

Deprecated all versions of flat without the fix.

Thanks a lot

@MatthiasKunnen MatthiasKunnen deleted the unflatten-prototype-pollution branch August 18, 2020 21:11
@DevRCRun
Copy link

hello

I'm here following a snyk report looking for the 4.1.2 release as it doesn't appear to be available via npm, the same looks to have been true of 4.1.1

#110

Could you push the new major versions there please? (unless I'm missing something obvious!)

@timoxley
Copy link
Contributor

@DevRCRun Fixed.

@cythrawll
Copy link

So our group fails builds if they have a certain SYNK threshold package in them. The SYNK says latest fixed version is 4.1.2 so a build with 4.1.1 doesn't meet the criteria. Can either 4.1.2 be published for this or SYNK corrected?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prototype Pollution
5 participants