Skip to content

Commit

Permalink
RevWalker returns True when commit is pushed sync.
Browse files Browse the repository at this point in the history
  • Loading branch information
Sam committed Apr 3, 2011
1 parent 6bc0679 commit 0027893
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion src/rev_walker.cc
Expand Up @@ -113,6 +113,9 @@ Handle<Value> RevWalker::Push(const Arguments& args) {
// EIO threadpool? I think it should be ok since we're not
// referencing the js object, but just the underlying commit itself
// which shouldn't get gc'd.
// FIXME: No, with the new libgit2 changes the git_commit is freed
// when the wrapping object is gc'd. We need to make sure that doesn't
// happen.
//request->commit->Ref();
}
else {
Expand Down Expand Up @@ -150,7 +153,7 @@ Handle<Value> RevWalker::Push(const Arguments& args) {
if(res != GIT_SUCCESS)
THROW_GIT_ERROR("Couldn't push commit onto walker.", res);

return scope.Close(Undefined());
return scope.Close(True());
}
}

Expand Down

0 comments on commit 0027893

Please sign in to comment.