Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Alex ikanow website deduplication improvement #164

Merged
merged 6 commits into from Feb 13, 2014

Conversation

Projects
None yet
2 participants
Owner

cantino commented Feb 13, 2014

Small improvements on #154

Alex-Ikanow and others added some commits Jan 30, 2014

#135 #141 2 deduplication fixes for the website agent
Fix 1) #135 update events' expiry date on deduplication

Previously events would age out even when being de-duplicated
frequently, resulting in spurious identical events making their way to
the next agent in the pipeline. This isn't the most efficient code (same
as previously), but not worth optimizing further until we've decided
what to do with a more generic deduplication module

Fix 2) #135 set deduplication "look back" to be configurable (and
default to a large number)

I think this is preferable default behavior? Potential performance
issues should be addressed via an efficient deduplication library using
indexed DB fields
#154 Fixed indentation (website deduplication improvements)
Pesky siren tab key calling out to me as I type!

cantino added a commit that referenced this pull request Feb 13, 2014

Merge pull request #164 from cantino/Alex-Ikanow-website_deduplicatio…
…n_improvement

Alex ikanow website deduplication improvement

@cantino cantino merged commit 5b54cde into master Feb 13, 2014

1 check passed

default The Travis CI build passed
Details

@cantino cantino deleted the Alex-Ikanow-website_deduplication_improvement branch Feb 13, 2014

DataMinerUK pushed a commit to DataMinerUK/huginn that referenced this pull request Oct 6, 2014

Merge pull request #164 from cantino/Alex-Ikanow-website_deduplicatio…
…n_improvement

Alex ikanow website deduplication improvement
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment