Heroku deployment! #404

Merged
merged 8 commits into from Jul 26, 2014

Conversation

Projects
None yet
5 participants
Owner

cantino commented Jul 19, 2014

It only took me 2 years! Appreciate any code feedback and testing that you can provide. Just checkout the heroku branch and run bin/setup_heroku.

This was referenced Jul 19, 2014

Coverage Status

Coverage remained the same when pulling 8781fd1 on heroku into d0a8446 on master.

naiyt commented Jul 19, 2014

Nice, @cantino! Giving it a shot now. Noticed a minor issue with bin/setup_heroku:

If you choose no after "Your Heroku app name is ***. Is this correct?" it just prints "Well, I'm not sure what to do here, sorry" and continues through the script normally. Did you mean to have it exit on line 78, or give instructions on how to change the app name?

Owner

cantino commented Jul 19, 2014

Haha, yup, it should exit.

Coverage Status

Coverage remained the same when pulling 0c63622 on heroku into d0a8446 on master.

Owner

cantino commented Jul 26, 2014

Does anyone have any feedback about the Heroku deployment? Is this ready for master?

naiyt commented Jul 26, 2014

I've been running it on Heroku for a week with 0 issues. It works great.

cantino added a commit that referenced this pull request Jul 26, 2014

@cantino cantino merged commit fcc97dd into master Jul 26, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details

@cantino cantino deleted the heroku branch Jul 26, 2014

Owner

cantino commented Jul 26, 2014

Thanks @naiyt! Merging

Owner

cantino commented Aug 21, 2014

The thing is that the setup script is interactive and lets you set a username and password, among other things. The Heroku Button doesn't do that yet. But if you want to dynamically generate the Heroku config from a web service with a form, or something, that'd be really slick!

Collaborator

knu commented Aug 21, 2014

The Heroku button spec has the way to create a config variable with a random secret string value that can be retrieved via the heroku command. I have one (app.json) work-in-progress which I'll tackle further some time later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment