Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nyan. #1

Merged
merged 1 commit into from Mar 9, 2020
Merged

Add nyan. #1

merged 1 commit into from Mar 9, 2020

Conversation

@joeheyming
Copy link
Contributor

joeheyming commented Mar 7, 2020

@joeheyming joeheyming mentioned this pull request Mar 7, 2020
@hugomd hugomd self-requested a review Mar 9, 2020
@hugomd
hugomd approved these changes Mar 9, 2020
Copy link
Owner

hugomd left a comment

Thanks for taking the time to contribute, it's much appreciated!

This looks great!

@hugomd hugomd merged commit 17fac40 into hugomd:master Mar 9, 2020
@hugomd

This comment has been minimized.

Copy link
Owner

hugomd commented Mar 9, 2020

Your change is live, if you want to try curl ascii.live/nyan 🐱 🚀

@joeheyming

This comment has been minimized.

Copy link
Contributor Author

joeheyming commented Mar 9, 2020

Thanks for accepting it.

I don't think I agree with the pattern of putting all the frames in one file, but I was able to adapt for the sake of getting out a pull request.

I would love to hear your thoughts on my PR for parrot.live

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.