make fonts changeable. Fixes #10 - #15
Merged
Merged
Conversation
Folyd
reviewed
Feb 10, 2023
Folyd
left a comment
Folyd
left a comment
Member
There was a problem hiding this comment.
LGTM, just a little nit-picks, thanks for working on this.
| ```html | ||
| {% extends "juice/templates/index.html" %} | ||
| {% block fonts %} | ||
| <link rel="stylesheet" href="https://cdn.jsdelivr.net/npm/fork-awesome@1.2.0/css/fork-awesome.min.css" |
Member
There was a problem hiding this comment.
I suggest removing this link to keep the example as simple as possible.
Contributor
Author
There was a problem hiding this comment.
I have shortened it, but I want to show an alternative to fonts.google.com.
Comment on lines
+84
to
+91
| `@import`-lines. | ||
|
|
||
| ```scss | ||
| @import "../themes/juice/sass/_ultility.scss"; | ||
| @import "_text.scss"; | ||
| @import "../themes/juice/sass/_markdown.scss"; | ||
| ... | ||
| ``` |
Member
There was a problem hiding this comment.
I didn't get why we need to copy those scss files
Contributor
Author
There was a problem hiding this comment.
I changed the font-selection to variables. So it's changeable in the _variables.html file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.