Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature flags: should optional dependencies also show in feature flags? #29

Closed
jmjoy opened this issue Apr 15, 2020 · 3 comments
Closed
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@jmjoy
Copy link

jmjoy commented Apr 15, 2020

Just a advise, like:

https://github.com/servo/rust-url/blob/28314752bf138a87bd8151f610d385629dec5710/Cargo.toml#L43

There is no [features] section in Cargo.toml, but serde is a feature of url, I can use it in my Cargo.toml:

url = { version = "2.1.1", features = ["serde"] }

So should this optional dependency show in Feature flags?

@Folyd Folyd added enhancement New feature or request help wanted Extra attention is needed labels Apr 15, 2020
@Folyd
Copy link
Member

Folyd commented Apr 15, 2020

Sounds good. Thanks for the suggestion and welcome to give PR. :)

@jmjoy
Copy link
Author

jmjoy commented Apr 17, 2020

I'm not familiar with JS. 😂

@Folyd
Copy link
Member

Folyd commented Mar 1, 2022

Hi, @jmjoy. We finally support show option dependencies!👏👏 See 8b81fc7.

image

@Folyd Folyd closed this as completed Mar 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants