Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #211

Closed
wants to merge 1 commit into from
Closed

Update README.md #211

wants to merge 1 commit into from

Conversation

lucas-lm
Copy link

Changelog from version 2.0.0 says that support for Python 3.6 was removed. Also, TOML file only refers to Python >=3.7

Copy link
Collaborator

@hauntsaninja hauntsaninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for spotting this!

We should probably update the version spec in this section to tomli >= 1.2.3 to make it more "seamless" with tomllib.

(Also technically tomli only dropped 3.6 support in v2, so the instructions here would still work for 3.6. About 6% of tomli downloads are on 3.6, so it's possible there's still some value here)

@hukkin
Copy link
Owner

hukkin commented Nov 1, 2022

Hello!

Please see #194

I don't think we need these changes. The instructions should work as they are, because pip (and any other well-behaved installer) will read the requires-python metadata and install tomli < 2.0.0on Python 3.6. Tomli 1.2.3 has zero known bugs, and were someone to find one, I'd have no problem making a 1.2.4 bugfix release.

We should probably update the version spec in this section to tomli >= 1.2.3 to make it more "seamless" with tomllib.

The current tomli >= 1.1.0 should suffice IMO because Tomli 1.1.0 doesn't lack any features that would be present in 1.2.*. The 1.2 minor bump only adds a deprecation.

@hauntsaninja
Copy link
Collaborator

Technically 1.2.3 added support for lower case "t" and "z" in datetimes

@hukkin
Copy link
Owner

hukkin commented Nov 2, 2022

Yeah, I guess there's always some ambiguity whether a change is a feature or a bugfix. It was never my intent to not respect the spec here so this felt like a bugfix to me at the time.

Anyways, v1.1.0 has the same API as up-to-date Tomli, and should work fine 99.9% of the time, so I don't see much need to change these numbers. An installer should prefer the latest compatible release anyways so I think it's better to be permissive.

@hukkin hukkin closed this Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants