New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lock a job when starting it #41

Closed
joehoyle opened this Issue Dec 19, 2017 · 2 comments

Comments

Projects
None yet
2 participants
@joehoyle
Member

joehoyle commented Dec 19, 2017

Right now we are seeing jobs being run more than once simultaneously because a job's "lock" is not quite atomic. We should probably use a SELECT... FOR UPDATE in https://github.com/humanmade/Cavalcade-Runner/blob/master/inc/class-runner.php#L221

@rmccue

This comment has been minimized.

Show comment
Hide comment
@rmccue

rmccue Dec 20, 2017

Member

This should already be handled?

Member

rmccue commented Dec 20, 2017

This should already be handled?

@joehoyle

This comment has been minimized.

Show comment
Hide comment
@joehoyle

joehoyle May 22, 2018

Member

Yeah, not sure how I didn't see that

Member

joehoyle commented May 22, 2018

Yeah, not sure how I didn't see that

@joehoyle joehoyle closed this May 22, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment