Skip to content
This repository has been archived by the owner on Oct 13, 2020. It is now read-only.

wordpress.org version needs updating #99

Closed
shampine opened this issue Jan 24, 2014 · 7 comments
Closed

wordpress.org version needs updating #99

shampine opened this issue Jan 24, 2014 · 7 comments
Assignees

Comments

@shampine
Copy link

The version available on wordpress.org on line 202 of wpthumb.php has

return reset( explode( '?', $this->file_path ) );

which throws errors about a non-variable being passed by reference. It seems to have been fixed in master on github just the wp.org version needs updating.

I tested by replacing wpthumb.php from master and the issue does subside.

@shampine
Copy link
Author

Also wp.org version is missing wpthumb.shortcodes.php.

@nciske
Copy link

nciske commented Feb 17, 2014

+1 for a push from master to WP.org.

Current WP.org version broke Soliloquy in 3.8.1 for me, but the GitHub version plays nicely.

@mattheu
Copy link
Member

mattheu commented Feb 20, 2014

@joehoyle Is the latest code on Github good for a release - I can do this if you need

@joehoyle
Copy link
Member

@mattheu that would be great, thanks! Master now is fine

@shampine
Copy link
Author

This still has not yet been updated on WP.org as that version breaks on 3.8.1 in wp-admin with:

Strict Standards: Only variables should be passed by reference in /content/plugins/wp-thumb/wpthumb.php on line 202

Would love it if you could sync the versions soon. Thanks. Master branch on github functions fine with 3.8.1.

@joehoyle
Copy link
Member

joehoyle commented Apr 1, 2014

@mattheu could you take care of updating the plugin on wordpress.org?

@willmot willmot assigned mattheu and unassigned joehoyle Apr 1, 2014
@shampine
Copy link
Author

shampine commented Apr 1, 2014

Looks like he updated it and the wp.org version is working correctly. Appreciate it, now I can finally switch all my git submodules out for the actual WP plugin. Cheers!

Closing the issue.

@shampine shampine closed this as completed Apr 1, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants