-
Notifications
You must be signed in to change notification settings - Fork 32
wordpress.org version needs updating #99
Comments
Also wp.org version is missing wpthumb.shortcodes.php. |
+1 for a push from master to WP.org. Current WP.org version broke Soliloquy in 3.8.1 for me, but the GitHub version plays nicely. |
@joehoyle Is the latest code on Github good for a release - I can do this if you need |
@mattheu that would be great, thanks! Master now is fine |
This still has not yet been updated on WP.org as that version breaks on 3.8.1 in wp-admin with: Strict Standards: Only variables should be passed by reference in /content/plugins/wp-thumb/wpthumb.php on line 202 Would love it if you could sync the versions soon. Thanks. Master branch on github functions fine with 3.8.1. |
@mattheu could you take care of updating the plugin on wordpress.org? |
Looks like he updated it and the wp.org version is working correctly. Appreciate it, now I can finally switch all my git submodules out for the actual WP plugin. Cheers! Closing the issue. |
The version available on wordpress.org on line 202 of wpthumb.php has
return reset( explode( '?', $this->file_path ) );
which throws errors about a non-variable being passed by reference. It seems to have been fixed in master on github just the wp.org version needs updating.
I tested by replacing wpthumb.php from master and the issue does subside.
The text was updated successfully, but these errors were encountered: