This repository has been archived by the owner on Mar 30, 2018. It is now read-only.
Add PHPUnit 6 support #270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theofidry
force-pushed
the
bugfix/phpunit-6
branch
from
de123f0
to
1284b75
Compare
robertbasic
reviewed
Oct 8, 2017
tests/ContainerTest.php
Outdated
| @@ -27,6 +27,11 @@ public function setup() | |||
| $this->container = new Container(['timeout'=>10]); | |||
| } | |||
|
|
|||
| public function tearDown() | |||
| { | |||
| m::close(); | |||
There was a problem hiding this comment.
I would suggest using the \Mockery\Adapter\Phpunit\MockeryPHPUnitIntegration trait as it will automatically call close() and increase the assertion counts for you.
added 2 commits
October 8, 2017 11:15
|
Thanks for the review @robertbasic :) |
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.