New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Escape result values in links #35

Closed
Crevil opened this Issue Jan 5, 2018 · 6 comments

Comments

Projects
None yet
3 participants
@Crevil
Copy link

Crevil commented Jan 5, 2018

When grouping results a link to a query is generated to the events related to the group.

If the results contain a " they are not escaped when inserted into the query.

  • Humio Version
    2017-12-18T13-59-11--build-1480--sha-c3d4e89c0a646a940b7ef846257918f4baf6f987

  • Browser Version
    Chrome Version 63.0.3239.84

  • Query Examples

With events with msg field:

Some id "id" did something cool
Some id "id" did something bad

When grouping by msg:

groupby(msg)

The result is:

msg                              _count
Some id "id" did something cool  1
Some id "id" did something bad   1

When clicking the links on each message group the resulting query becomes

groupby(msg) | "msg"="Some id "id" did something cool"
@pmech

This comment has been minimized.

Copy link
Contributor

pmech commented Jan 5, 2018

Thanks! We'll look into this

@anagrius

This comment has been minimized.

Copy link
Collaborator

anagrius commented Jan 12, 2018

I will try to fix this on monday. Should be a quick one. I guess it is only double quotes that are impacted right? No other special characters we can think of?

@Crevil

This comment has been minimized.

Copy link

Crevil commented Jan 13, 2018

@anagrius

This comment has been minimized.

Copy link
Collaborator

anagrius commented Jan 17, 2018

Sorry, I only just started looking at this now. Should be included in the next release

@anagrius

This comment has been minimized.

Copy link
Collaborator

anagrius commented Jan 17, 2018

This was actually also a problem for fields with names containing spaces.

It is fixed now and will be part of the next release.

@anagrius anagrius closed this Jan 17, 2018

@Crevil

This comment has been minimized.

Copy link

Crevil commented Jan 17, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment