optional extension for graphic command

[MAKIO135]

Since using .gif / .png with the graphic command is the reason for multiple forks, setting extension could be optional:

'graphic': (p) => { terminal.theme.setImage(terminal.source.locate(p.parts[0] + '.' + (p.parts[1] || 'jpg'))) },

.jpg would still be the default extension, thus not breaking anything, but anyone could use .gif and other supported formats for background-image (PNG, SVG, JPG, GIF, WEBP)

-> Usage: graphic:1;gif

Instead of the current fixed .jpg extension:

'graphic': (p) => { terminal.theme.setImage(terminal.source.locate(p.str + '.jpg')) },

Orca/desktop/sources/scripts/commander.js

Line 42 in 21a5b46

'graphic': (p) => { terminal.theme.setImage(terminal.source.locate(p.str + '.jpg')) },

[neauoire]

I like it, I think the full extension is better so I don't have to make changes anytime someone want to add a new one.

[MAKIO135]

Yes, plus prevents jpg / jpeg errors

[neauoire]

• Implemented gr:name;ext.
• Also implemented a $ operator that automatically sends the command to Orca, without going through UDP! Like $gr:0;gif

[martinberlin]

The $ dollar sign definitely does not work on my Ubuntu PC.
The only things I can see with SHIFT pressed and the numbers are: !%

Or this only though to be like a command using Ctrl+K?

[neauoire]

You're supposed to be able to type the $ character into the grid.
Dunno why it's not working for you.

[martinberlin]

It's maybe something to do that I'm using Gnome and Ubuntu 18? Did someone tried this on Ubuntu?
But the funny thing is that it works on the command Orca CTRL-K so it's really strange I would love to know if someone else can help me out find what it is, since it's really bugging me.

[MAKIO135]

Which version number of Orca are you using?

[martinberlin]

The last one that is available on master branch. Wrong-> I just checked and it's like 2 weeks old, so I will pull again when home and test it again. Sorry my bad!

[martinberlin]

Everything working as expected. Turns out apart of pulling latest master I had to make a npm install to get the latest vendor updates. Is working as expected now many thanks to all the team

[neauoire]

I'm glad to hear :)