Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Midi Clock Out #74

Closed
neauoire opened this issue Apr 12, 2019 · 6 comments
Closed

Add Midi Clock Out #74

neauoire opened this issue Apr 12, 2019 · 6 comments
Labels

Comments

@neauoire
Copy link
Member

@neauoire neauoire commented Apr 12, 2019

Work started, but interrupts the midi signal.

See this.

@neauoire neauoire changed the title Midi's clock output stream is breaking midi signal? Add Midi Clock Out May 11, 2019
@neauoire neauoire added enhancement and removed bug help wanted labels May 11, 2019
@okyeron
Copy link
Contributor

@okyeron okyeron commented Jul 1, 2019

Is there a branch for the work on this so far?

I just did midi program change and thought maybe midi clock could work similarly - just have an operator that gets banged to send midi clock message - rather than wrapping that into the midi keys/notes stuff

Not sure I fully understand the code linked above, but midi clock is either on all the time or off, regardless of midi start/stop messages

@neauoire
Copy link
Member Author

@neauoire neauoire commented Jul 1, 2019

no but I think the clock code is still in clock.js

@okyeron
Copy link
Contributor

@okyeron okyeron commented Jul 2, 2019

I'm not making sense of the clock code so I'm not sure how to implement this myself yet.... but here's an idea for Clock Out:

Add a Send MIDI Clock option to the Clock menu. If this is on, then just send a stream of this.outputDevice().send([0xF8]) at 24 ppq with the current tempo. I don't think it needs to be tied to transport control.

Then... maybe midi start/stop commands could be mapped to the spacebar start/stop function?

@okyeron
Copy link
Contributor

@okyeron okyeron commented Jul 13, 2019

WIP - this works over here. Maybe needs some more testing?
https://github.com/okyeron/Orca-1/tree/midi-clock

@okyeron
Copy link
Contributor

@okyeron okyeron commented Jul 15, 2019

#167

Close Issue?

@neauoire
Copy link
Member Author

@neauoire neauoire commented Jul 15, 2019

YESH! Thanks a lot that's an old one too, I've wanted this for a long time

@neauoire neauoire closed this Jul 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants