Skip to content

Commit 5859132

Browse files
chore: more specific variable names
1 parent 7ba0fed commit 5859132

File tree

3 files changed

+8
-8
lines changed

3 files changed

+8
-8
lines changed

docs/guide/toolbar.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -25,8 +25,8 @@ Bold.configure({
2525
```jsx
2626
<RichTextEditor
2727
toolbar={{
28-
render: (props, dom, domContent, containerDom) => {
29-
return containerDom(domContent)
28+
render: (props, toolbarItems, dom, containerDom) => {
29+
return containerDom(dom)
3030
}
3131
}}
3232
/>
@@ -50,6 +50,6 @@ export interface ToolbarRenderProps {
5050
disabled: boolean
5151
}
5252
export interface ToolbarProps {
53-
render?: (props: ToolbarRenderProps, dom: ToolbarItemProps[], domContent: React.ReactNode, containerDom: (innerContent: React.ReactNode) => React.ReactNode) => React.ReactNode
53+
render?: (props: ToolbarRenderProps, toolbarItems: ToolbarItemProps[], dom: JSX.Element[], containerDom: (innerContent: React.ReactNode) => React.ReactNode) => React.ReactNode
5454
}
5555
```

src/components/Toolbar.tsx

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ export interface ToolbarComponentProps {
1515
function Toolbar({ editor, disabled, toolbar }: ToolbarComponentProps) {
1616
const { t, lang } = useLocale()
1717

18-
const items = useMemo(() => {
18+
const toolbarItems = useMemo(() => {
1919
const extensions = [...editor.extensionManager.extensions]
2020
const sortExtensions = extensions.sort((arr, acc) => {
2121
const a = (arr.options).sort ?? -1
@@ -81,7 +81,7 @@ function Toolbar({ editor, disabled, toolbar }: ToolbarComponentProps) {
8181
)
8282
}
8383

84-
const domContent = items.map((item: ToolbarItemProps, key) => {
84+
const dom = toolbarItems.map((item: ToolbarItemProps, key) => {
8585
const ButtonComponent = item.button.component
8686

8787
return (
@@ -99,10 +99,10 @@ function Toolbar({ editor, disabled, toolbar }: ToolbarComponentProps) {
9999
})
100100

101101
if (toolbar && toolbar?.render) {
102-
return toolbar.render({ editor, disabled: disabled || false }, items, domContent, containerDom)
102+
return toolbar.render({ editor, disabled: disabled || false }, toolbarItems, dom, containerDom)
103103
}
104104

105-
return containerDom(domContent)
105+
return containerDom(dom)
106106
}
107107

108108
export { Toolbar }

src/types.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -235,7 +235,7 @@ export interface ToolbarRenderProps {
235235
disabled: boolean
236236
}
237237
export interface ToolbarProps {
238-
render?: (props: ToolbarRenderProps, dom: ToolbarItemProps[], domContent: React.ReactNode, containerDom: (innerContent: React.ReactNode) => React.ReactNode) => React.ReactNode
238+
render?: (props: ToolbarRenderProps, toolbarItems: ToolbarItemProps[], dom: JSX.Element[], containerDom: (innerContent: React.ReactNode) => React.ReactNode) => React.ReactNode
239239
}
240240

241241
export interface NameValueOption<T = string> {

0 commit comments

Comments
 (0)