Line separator System property fails

[gpolet]

Using the system property JDOMConstants.JDOM2_PROPERTY_LINE_SEPARATOR does not work and creates faulty documents with the value of the property instead of the value of the LineSeparator enum.

Calling System.setProperty(JDOMConstants.JDOM2_PROPERTY_LINE_SEPARATOR, "SYSTEM"); before anything else should make the system line separator the default line separator when serializing. Instead, the default line separator is initialized to the String value "SYSTEM".

Here is a test that currently fails with version 2.0.4 of JDom (Java 6 or Java 7):

package org.flexo.model;

import junit.framework.Assert;

import org.jdom2.JDOMConstants;
import org.jdom2.output.LineSeparator;
import org.junit.Test;

public class TestJDomLineSeparator {

    @Test
    public void testLineSeparatorFromSystemProperty() {
        System.setProperty(JDOMConstants.JDOM2_PROPERTY_LINE_SEPARATOR, "SYSTEM");
        Assert.assertEquals(System.getProperty("line.separator"), LineSeparator.DEFAULT.value());
    }
}

It seems that calling final LineSeparator sep = Enum.valueOf(LineSeparator.class, prop); throws an IllegalArgumentException when called during the initialization of the enum. The exception is silently caught and the system property is immediately returned (this last part does not make sense).

[rolfl]

Hmmm... I have tested the code. I wonder whether this code changed in a later version of Java.... but, I agree. it is broken right now.

Stil investigating.

[rolfl]

Oh, and the reason the exception is silently ignored is for those times when you want your separator to be 'jinglebells', or some value that is not the defined name for a constant.