Serialization is inconsistent and incomplete. #47

Closed
rolfl opened this Issue Oct 3, 2011 · 1 comment

Comments

Projects
None yet
1 participant
Collaborator

rolfl commented Oct 3, 2011

THe serialization of all classes in JDOM needs to be audited and corrected, as well as tested.

rolfl closed this in 7a9d980 Feb 1, 2012

rolfl reopened this Feb 12, 2012

Collaborator

rolfl commented Feb 12, 2012

serializing Element.getChildren() causes there to be new instances of Child Elements that use the current Element as the Parent node, but the current Parent only points to the pre-serialization child nodes as content....

i.e. the newly 'cloned' Child Elements should be detached, but they are not.

@rolfl rolfl added a commit that referenced this issue Feb 12, 2012

@rolfl rolfl Issue #47 - broken serialization example 9957220

@rolfl rolfl added a commit that referenced this issue Feb 14, 2012

@rolfl rolfl Issue #47 - Serialization audit
Use SerialVersionUID 200L (version 2.0.0).
Rework core serialization:
 - all Content is 'detached' now after serialization (but Element and Document re-attache where required on deserialization).
 - Namespace is now serializable
Remove the 'new' JDOMRuntimeException, replace it with core Java Illegal*Exceptions.
Add serialization tests to Filter classes. Filters are still serializable, not sure why that is needed.
Fiox up some code coverage tests.... including complicated 'Bridge Methods' for co-variant return-type bridge methods.
0424a4b

rolfl closed this in 7307ae5 Feb 14, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment