New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AttributeList.add(Attribute) does double-calls to slow method indexOfDuplicate(Attribute) #91

Closed
rolfl opened this Issue Sep 1, 2012 · 0 comments

Comments

Projects
None yet
1 participant
@rolfl
Collaborator

rolfl commented Sep 1, 2012

As reported by Wilf, performance degradation because indexOfDuplicate(Attribute) call is done multiple times when adding an Attribute, causing a performance degradation.

@rolfl rolfl closed this in 4085484 Sep 1, 2012

rolfl added a commit that referenced this issue Sep 9, 2012

Issue #91 - AttributeList double-check of duplicate fix....
The fix for this check results in some checks being done in a few places, and not all of these places were covered in the test-harness, resulting in uncovered code. This commit ensures that all places that check attributes now have appropriate test cases.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment